Repository navigation
More pride watch faces - #2438
Merged
Merged
Conversation
Contributor
Author
|
|
Build size and comparison to main:
|
mark9064
reviewed
May 11, 2026
mark9064
left a comment
mark9064
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution!
Would you say readability of all the faces is good enough colour contrast wise?
Also, you might want to test them with always on display. Ideally the key watchface information will stay readable (the colours will be butchered as there's only 8)
Contributor
Author
|
@mark9064 contrast is good for all new faces and the time remains visible in always on mode |
mark9064
approved these changes
May 13, 2026
mark9064
left a comment
mark9064
left a comment
Member
There was a problem hiding this comment.
Haven't hardware tested but LGTM. Thanks :)
This was referenced May 25, 2026
Member
|
I have no clue why this uses 1K of extra space, that would be equivalent to 300 new colours? But whatever, we can optimise if it's an issue :) |
Contributor
Author
|
My guess is it's related to memory alignment, I can try and look into it a
little bit.
Best regards,
Nick Garnsworthy
…On Fri, Oct 23, 2026, 18:35 mark9064 ***@***.***> wrote:
*mark9064* left a comment (InfiniTimeOrg/InfiniTime#2438)
<#2438 (comment)>
I have no clue why this uses 1K of extra space, that would be equivalent
to 300 new colours? But whatever, we can optimise if it's an issue :)
—
Reply to this email directly, view it on GitHub
<#2438?email_source=notifications&email_token=AF3VJ4XB44YQXLAJLBWF6C35VPTNDA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMZXGY4DMOJXGE22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6376869715>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF3VJ4RK34MCNG7L7RP3TPL5VPTNDAVCNFSNUABFKJSXA33TNF2G64TZHMZDENRRGY3TMMRQHNEXG43VMU5TINBRGY3DKMZVGU4KC5QC>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
watchface: added more pride flags to the pride watch face